[MPlayer-dev-eng] RN5 authentication for rtsp
uoti.urpala at pp1.inet.fi
Wed Mar 26 23:28:55 CET 2008
On Wed, 2008-03-26 at 18:10 -0400, Paul wrote:
> > at a quick glance there are still cosmetics in the initial part of your patch
> I can't see it. The extra indentation is neccessary IMHO.
It is necessary for the final version. However you reindent a fairly
large block of code, and it's not immediately obvious which part is only
supposed to be reindented and which otherwise changed. In this case I
think "diff -b" output is easier to read. Of course it's easy for
everyone to generate diff -b output themselves if they first apply the
patch, but it's harder to read the patch directly from the mail reader.
Attached is "git diff -b" output with the patch applied.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 3205 bytes
Desc: not available
More information about the MPlayer-dev-eng