[MPlayer-dev-eng] RN5 authentication for rtsp

[Paul]

On Wed, 26 Mar 2008, Nico Sabbi wrote:

> Date: Wed, 26 Mar 2008 22:20:18 +0100
> From: Nico Sabbi <Nicola.Sabbi at poste.it>
> Reply-To: mplayer-dev-eng at mplayerhq.hu
> To: mplayer-dev-eng at mplayerhq.hu
> Subject: Re: [MPlayer-dev-eng] RN5 authentication for rtsp
> 
> Il Wednesday 26 March 2008 19:40:38 Paul ha scritto:
>>
>> Here's an updated patch with some bound checking on strings and proper
>> gargabe collection. There are no cosmetic changes
>
> at a quick glance there are still cosmetics in the initial part of your patch

I can't see it. The extra indentation is neccessary IMHO.

>
>> to the code AFAIK. I had
>> to indent the original Basic auth code to allow for other possible
>> authentication methods blocks.
>>
>> I've also attached another patch to use the username/passwd command line
>> arguments if none are supplied as part of the URL.
>
> why? username and password should always be in the stream syntax.

If they should always be in the stream syntax, what is the purpose of the 
-user and -passwd options ? I've expanded its functionality to rtsp 
streams. Are these options considered obsolete ?

>From manpage:
 	-user <username> (also see -passwd) (network only)
               Specify username for HTTP authentication.
 	-passwd <password> (also see -user) (network only)
               Specify password for HTTP authentication.

Paul