[MPlayer-dev-eng] [PATCH] mmap support for OS/2

[KO Myung-Hun]

HI/2.

Alexander Strasser wrote:
> Hi!
>
> KO Myung-Hun wrote:
> [...]
>   
>>>> +static os2_mmap *_mmap = NULL;
>>>>    
>>>>         
>>> Identifiers starting with _ and lowercase are reserved at the file
>>> level.  You are not using it outside this file, but it's still ugly.
>>>
>>>  
>>>       
>> Ok. I prepend 'm'.
>>     
>
>   I know this case is outdated. But I still have a little
> comment for it that might be useful for similar future
> cases.
>
>   In C one usually has the freedom to name file scoped
> variables (declared static outside any functions) `naturally'.
> Sorry, I don't know a better adjective right now.
>
>   For example an IMHO `natural' name for this concrete example
> would have been mmaps, mmappings, mmap_infos, mmap_list etc.
>   For me this is magnitudes more readable than _mmap or
> m_mmap. What is the m_ prefix meaning anyway, it is from
> a reading point of view even more irritating than its
> predecessor.
>
>   

It means 'module', that is, static variables outside any functions.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 1.1.8
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1 GHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr