[MPlayer-dev-eng] [PATCH] Win32 loader for OS/2

[Diego Biurrun]

On Mon, Mar 03, 2008 at 10:45:03PM +0900, KO Myung-Hun wrote:
> 
> Diego Biurrun wrote:
> >>>> --- loader/Makefile (revision 26108)
> >>>> +++ loader/Makefile (working copy)
> >>>> @@ -35,6 +35,11 @@
> >>>>  +ifeq ($(TARGET_OS),OS/2)
> >>>> +wrapper.o : wrapper.S
> >>>> +   $(CC) -Zomf -c -o $@ $^
> >>>> +endif
> >>>>         
> >>> What's the problem here?
> >>>       
> >> Default output of gcc on OS/2 is a.out format. But overall format of 
> >> MPlayer OS/2 port require OMF format. So without that, librarian cannot 
> >> recognize it.
> >
> > I don't understand, -Zomf is added unconditionally to CFLAGS on OS/2.
> > So why are you leaving out CFLAGS here?
> 
> I thought as you. But it did not.
> 
> I know, there are no any implicit rules in both config.mak and 
> mpconfig.mak at all.  But make seems to assume default implicit rules 
> for %.o and %.c to
> 
> %.o : %.c
>     $(CC) $(CFLAGS) -c -o $@ $<
> 
> In case of %.o and %.S,
> 
> $.o : %.S
>     $(CC) $(ASFLAGS) -c -o $@ $<
> 
> So, without implicit rules for .c files, compilation could be completed 
> as expect. But in case of .S, compilation is not performed as expect, 
> because ASFLAGS is not defined.
> 
> I tested this with GNU Make 3.81 for OS/2.
> 
> And you can confirm what the flags are used to compile wrapper.S by 
> using delete wrapper.o and call make.
> 
> Can you see the options specified by CFLAGS ?
> 
> If so, I think this is a problem specific to OS/2 and this patch is in 
> right direction. Or mpcommon.mak should define implicit rule for %.o and 
> %.S or 'ASFLAGS'.

I think setting ASFLAGS in configure is the right solution.

Diego