[MPlayer-dev-eng] [PATCH] add 8 bit Bayer format and filter

[Guennadi Liakhovetski]

On Mon, 3 Mar 2008, Dominik 'Rathann' Mierzejewski wrote:

> On Monday, 03 March 2008 at 13:25, Guennadi Liakhovetski wrote:
> > On Mon, 3 Mar 2008, Dominik 'Rathann' Mierzejewski wrote:
> > 
> > > On Monday, 03 March 2008 at 12:06, Guennadi Liakhovetski wrote:
> > > > diff -u a/libmpcodecs/Makefile~ a/libmpcodecs/Makefile
> > > > --- a/libmpcodecs/Makefile~	2007-10-07 21:49:25.000000000 +0200
> > > > +++ a/libmpcodecs/Makefile	2008-02-21 12:17:13.000000000 +0100
> > > > @@ -94,6 +94,7 @@
> > > >                vf_yuy2.c \
> > > >                vf_yvu9.c \
> > > >                vf_ow.c \
> > > > +	      vf_ba81.c
> > > 
> > > Inconsistent spacing, lack of \ at the end.
> > 
> > No. The backslash at the end of the line is _not_ lacking in this case. It 
> > is correct. The backslash at the end of the line in Makefile indicates 
> > line continuation, and this is the last file in the list, hence no 
> > continuation.
> 
> You are wrong. We intentionally keep the backslash in the last line (see
> above) so that subsequent additions require changing just one line instead
> of two.

Which still doesn't mean it is correct. I understand what it is and why 
you do it and why it works - because the next line is empty. But if it is 
not, it will break.

Thanks
Guennadi
---
Guennadi Liakhovetski