[MPlayer-dev-eng] [PATCH] add 8 bit Bayer format and filter

[Reimar Döffinger]

On Mon, Mar 03, 2008 at 01:10:20PM +0100, Nico Sabbi wrote:
> On Monday 03 March 2008 13:03:08 Dominik 'Rathann' Mierzejewski wrote:
> > On Monday, 03 March 2008 at 12:06, Guennadi Liakhovetski wrote:
> > > Hi all
> > >
> > > This patch implements support for a new image format - 8 bit
> > > Bayer (BA81 / BYR1). To actually be able to represent the video a
> > > new filter has been written. In tests a command like
> > >
> > > mplayer -v tv:// -tv \
> > > driver=v4l2:input=0:width=640:height=480:device=/dev/video0:outfm
> > >t=ba81 \ -vf ba81 -vo fbdev
> > >
> > > has been used.
> >
> > I don't know if a new video filter is the correct solution.
> >
> > > The patch also fixes a couple of potential NULL pointer
> > > dereferences.
> >
> > Don't mix new features with bugfixes in one patch. Partial review
> > follows.
> >
> 
> new decoders belong to libavcodec

If it was a decoder, though it is more a colourspace converter and as
such would be more suitable in libswscale. Either way a filter is the
worst solution possible, and both of the better solutions should be
submitted to FFmpeg...