[MPlayer-dev-eng] [PATCH] fix v4l2 free_demuxer crash - uvcvideo

Vladimir Voroshilov voroshil at gmail.com
Mon Jun 30 19:48:16 CEST 2008


2008/6/27 Vladimir Voroshilov <voroshil at gmail.com>:
> 2008/6/25 Jindrich Makovicka <makovick at gmail.com>:
>> On Fri, 6 Jun 2008 18:38:05 +0200
>> Ötvös Attila <dc at chello.hu> wrote:
>>
>>> Ezzel a dátummal: Friday 30 May 2008 13.28.33 Vladimir Voroshilov ezt
>>> írta:
>>>
>>> Hi Vladimir Voroshilov!
>>>
>>> >
>>> > if (ioctl(priv->video_fd, VIDIOC_G_STD, &id) < 0) {
>> [...]
>>> >
>>> > And the rest of your patch is not needed.
>>> >
>>> > P.S. i didn't test code above.
>>> > P.P.S i don't know how much "hackish" is either my or your solution.
>>>
>>> I tested. It work.
>>
>> Nevertheless, it would still be nice to have some fallback when the fps
>> is really unknown. getfps() in the attachment should be consistent with
>> the fallback code in tv.c.
>
> Here is the same patch with cosmetics removed.
> I'll apply it tomorrow.

Applied as two separate patches:
one for division by zero fix, another - getting
 frame rate through VIDIOC_G_PARM.

-- 
Regards,
Vladimir Voroshilov mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719


More information about the MPlayer-dev-eng mailing list