[MPlayer-dev-eng] [PATCH] wid support with vo_sdl
Aurelien Jacobs
aurel at gnuage.org
Wed Jun 25 13:20:42 CEST 2008
Ricardo Salveti wrote:
> On Tue, Jun 24, 2008 at 8:20 AM, Aurelien Jacobs <aurel at gnuage.org> wrote:>
> > It won't compile when HAVE_X11 is not defined.
>
> True, forgot to put the xv code inside the ifdef.
>
> Here's the second version of the patch, please see if there's still
> any problem with it.
>
> [...]
>
> diff -Naur mplayer-trunk-old/libvo/vo_sdl.c mplayer-trunk-new/libvo/vo_sdl.c
> --- mplayer-trunk-old/libvo/vo_sdl.c 2008-06-25 01:20:51.000000000 -0300
> +++ mplayer-trunk-new/libvo/vo_sdl.c 2008-06-25 02:36:20.000000000 -0300
> @@ -793,12 +793,22 @@
> return -1;
>
> /* Set output window title */
> - SDL_WM_SetCaption (".: MPlayer : F = Fullscreen/Windowed : C = Cycle Fullscreen Resolutions :.", title);
> + if (WinID < 0)
> + SDL_WM_SetCaption (".: MPlayer : F = Fullscreen/Windowed : C = Cycle Fullscreen Resolutions :.", title);
Cosmetics.
(you shouldn't mix cosmetics and functionnal changes, which means, don't
reindent lines that you don't touch otherwise)
> - aspect_save_screenres(priv->XWidth,priv->XHeight);
> - aspect(&priv->dstwidth,&priv->dstheight,A_NOZOOM);
> + aspect_save_screenres(priv->XWidth,priv->XHeight);
> [...]
> + aspect(&priv->dstwidth,&priv->dstheight,A_NOZOOM);
Cosmetics.
Aurel
More information about the MPlayer-dev-eng
mailing list