[MPlayer-dev-eng] [PATCH] color SPU

[Ivan Kalvachev]

On 6/21/08, Benjamin Zores <ben at geexbox.org> wrote:
> Ivan Kalvachev a écrit :
>> On 6/21/08, Benjamin Zores <ben at geexbox.org> wrote:
>>> Ötvös Attila a écrit :
>>>> Hi All!
>>>>
>>>> I make color SPU to dvd subtitles and dvd menu.
>>>>
>>>> The first number show depend in patch.
>>>>
>>>> part1:
>>>> - add need format def
>>>> - add new paramater (dp) to all draw_alpha() functions
>>>>
>>>> part2:
>>>> - draw code to U, V, R, G and B planes
>>>> - query SPU format code (VFCTRL_GET_OSD_FORMAT)
>>>>
>>>> part3:
>>>> - modify spudec.c to UV and RGB planes (scale more plane)
>>>>
>>>> part4:
>>>> - add draw function to UV plane in vf_expand
>>>> - final modify in mplayer.c
>>>> - new options: -colorspu/-nocolorspu - enable/disable color spu
>>>>
>>>> part5:
>>>> - add palette variable to stream_dvdnav
>>>> - final modify to spudec
>>>> - add mp_dvdnav_highlight_handle() in mplayer.c
>>> Hi list,
>>>
>>> FYI, I'm decided t finally push theses patches ustream.
>>> If someone gets opposed, please say so now !
>> 
>> I oppose.
>
> Well well, no suprise there but can you develop a bit more ?
> I'm a bit fed up because:
> - many patches are supplied.
> - nobody cares about or wants to review them
> - everyone objects to everything
>
> All I hear is: "this is not the right approach to do things, though I 
> have no idea what the right one could be" ...

How about doing a little research first?

I have explained why this approach is nothing but the ugliest possible hack and have given recommendations the first time when this was introduced.
Now it  should be third of fourth time this stuff is introduces 
and afaics basic principle is the same.

Last time when same patches were introduced there was discussion about merging them with the EOSD (the stuff that renders ass/ssa subtitles).

A lot of people complain that mplayer code is ugly and hard to understand.
Adding such massive hack would not make the code prettier.
And no amount of cosmetics would help.