[MPlayer-dev-eng] [PATCH] Change lots of defines to one big enum.

[Ivan Kalvachev]

On 6/17/08, Benjamin Zores <ben at geexbox.org> wrote:
> Hi,
>
> Looking at this input/input.h file, I've found it pretty ugly to use
> dozens of defines to declare MPlayer type of commands.
> This simple patch makes them a big enum which:
>   - ease a lot application of external patches (no command number conflict)
>   - allows sorting commands per type/group (let's call this the Diego's
> work)
>   - order command alphabetically per group (Diego, if you read this and
> care ... :-)
>
> Anyone objects to this or may I apply ?

I like the idea.

I just wonder why are you making it into typedef
(are you planning or replacing current int with that type?)
and won't the mp_command_t be confused with mp_cmd_t that
already exists.

Best Regards