[MPlayer-dev-eng] [bikeshed] Coding style

Benjamin Zores ben at geexbox.org
Mon Jun 16 21:07:33 CEST 2008


Reimar Döffinger a écrit :
> On Mon, Jun 16, 2008 at 08:39:33PM +0200, Benjamin Zores wrote:
>> We might choose one well-known coding style because, obviously,
>> there is no chance that everyone agree on something to define an MPlayer 
>> one.
> 
> Well, in that case the far more logical choice would be to use FFmpeg
> style, at least as far as it is defined.


Would be the most consistent approach

> But I have the impression that some would want to just run indent over
> the source. I have a bit of a problem with that, since I very much doubt
> that anyone will review that, and from personal experience I can say
> that at least past indent versions _did_ break code in a way that it did
> not compile, so who can say not even worse things might happen?

Then agree on indent options and let maintainers call indent with the 
appropriate options on their files _only_, taking care it still works 
for them afterwards.

Sure, having a complete "indent *.[hc]" might be funny :-)

Ben



More information about the MPlayer-dev-eng mailing list