[MPlayer-dev-eng] [bikeshed] Coding style

Benjamin Zores ben at geexbox.org
Mon Jun 16 20:39:33 CEST 2008


Uoti Urpala a écrit :
> On Mon, 2008-06-16 at 13:45 +0200, Luca Barbato wrote:
>> Given that some people seems to be fine with the cleanup weekend here 
>> something to start a nice flame:
>>
>> We could decide a coding style and try to be consistent as much as possible.
>>
>> I like trying to leave spaces when possible but I like better having 
>> *pointer, conditional blocks should keep the bracket in the same line, 
>> functions the line immediately after.
> 
> Standard K&R style as generated by the -kr option of the indent program,
> without any "personal" variations. Some deviations can be allowed but
> they should be viewed as that, deviations from the recommended style.
> Trying to create an MPlayer-specific style is a bad idea which will
> cause unnecessary arguments without any real benefit and with real harm
> such as making the style less obvious to people not familiar with
> MPlayer.

I tend to agree on that.
We might choose one well-known coding style because, obviously,
there is no chance that everyone agree on something to define an MPlayer 
one.

Sure, some might not like the chosen one but it's a matter of tradeoff
and can't be worse that the current situation.

Ben



More information about the MPlayer-dev-eng mailing list