[MPlayer-dev-eng] Patch for a pause property
Joshua Isom
jrisom at gmail.com
Fri Jun 13 20:20:27 CEST 2008
On Jun 13, 2008, at 3:33 AM, Diego Biurrun wrote:
> On Thu, Jun 12, 2008 at 01:08:01PM -0500, Joshua Isom wrote:
>> On Jun 11, 2008, at 3:12 AM, Diego Biurrun wrote:
>>
>> From what I can see, the majority of functions in command.c use tabs
>> and spaces for an indentation of 12 spaces
>
> I haven't counted them, but things looked different to me at a glance.
> There is nothing stopping you from using only spaces in any case.
>
>> There's also an explicit refusal to patch based solely on whitespace.
>
> You are misunderstanding. Whitespace-only patches are not a problem
> and
> nothing is said about how new lines should be indented.
>
> Diego
>
Here's a patch with only spaces. Do you know where would be the best
spot to document that 'set_property pause 1' requires "pausing" or
"pausing_keep" to work? It's due to input commands unpausing
mplayer(including the get_property commands), so appears to not work at
first.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pause_prop.patch
Type: application/octet-stream
Size: 2191 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080613/722ee008/attachment.obj>
More information about the MPlayer-dev-eng
mailing list