[MPlayer-dev-eng] Patch for a pause property

[Diego Biurrun]

On Thu, Jun 12, 2008 at 01:08:01PM -0500, Joshua Isom wrote:
> On Jun 11, 2008, at 3:12 AM, Diego Biurrun wrote:
> 
> > On Wed, Jun 11, 2008 at 02:44:22AM -0500, Joshua Isom wrote:
> >>>>
> >>>> <patch-command.c>
> >>>
> >>> some quick comments:
> >>> - don't mix spaces and tabs for indentation
> >>> - add documentation to DOCS/tech/slave.txt
> >>
> >> The spaces and tabs are like that in command.c so I was just matching
> >> it.
> >
> > Umm, no, not really.  If you scroll down a bit, you will notice a lot 
> > of functions written without tabs.
> 
>  From what I can see, the majority of functions in command.c use tabs 
> and spaces for an indentation of 12 spaces

I haven't counted them, but things looked different to me at a glance.
There is nothing stopping you from using only spaces in any case.

> There's also an explicit refusal to patch based solely on whitespace.

You are misunderstanding.  Whitespace-only patches are not a problem and
nothing is said about how new lines should be indented.

Diego