[MPlayer-dev-eng] [RFC] importing libdvdread from the dvdnav repository

[Diego Biurrun]

On Sat, Jun 07, 2008 at 04:04:11PM +0200, Roberto Togni wrote:
> On Sat, 7 Jun 2008 11:31:13 +0200
> Nico Sabbi <Nicola.Sabbi at poste.it> wrote:
> 
> > As for $Subject: please consider dropping our dvdread directory and importing
> > the libdvdread/ directory from the dvdnav repository as an external component:
> > I fixed (with a lot of patches by other people) a considerable amount of bugs
> > and resource leaks.
> > The only thing missing is the static linking against our copy of dvdcss,
> > but it should be quite easy to add.
> > 
> > Opinions?
> 
> As long as it does not causes regressions (ie. you can still play an
> encrypted dvd with mplayer without the need of external libraries) I'm
> ok with it.

Seconded.

> -- 
> Better is the enemy of good enough.

I was never sure if I agreed with this, more and more, I do.

Diego