[MPlayer-dev-eng] The new Makefiles

[Diego Biurrun]

On Mon, Jun 02, 2008 at 05:18:49PM +0200, Diego Biurrun wrote:
> On Wed, May 28, 2008 at 07:11:48PM +0200, Alban Bedel wrote:
> > On Tue, 27 May 2008 19:19:25 +0200
> > Diego Biurrun <diego at biurrun.de> wrote:
> > 
> > > On Tue, May 27, 2008 at 07:39:26PM +0200, Alban Bedel wrote:
> > > > On Tue, 27 May 2008 14:14:45 +0200
> > > > Diego Biurrun <diego at biurrun.de> wrote:
> > > > 
> > > > > TOOLS/netstream and TOOLS/vivodump still do not link under any
> > > > > circumstances.
> > > > > 
> > > > > Albeu, you said you knew a way to fix this.  Let's hear it.
> > > > 
> > > > I sent you a patch showing you what is needed to link them, then
> > > > warned you from the start that the file list _MUST_ be kept
> > > > slitted. You just ignored everything.
> > > 
> > > No, I just disagreed that
> > > 
> > > a) splitting the lists is necessary;
> > 
> > OK, now I'm burning to find out how in hell you will manage to not
> > split the list while not duplicating half of it.
> 
> Attached is a hackish patch that makes vivodump link.  A big problem is
> the massive code duplication between mplayer.c and mencoder.c.  Better
> suggestions are welcome.

Here is an updated patch for both vivodump and netstream.  It's hackish
in the sense that it builds a separate object from mplayer.c, but I
don't see a better way except for massively refactoring mplayer.c.  This
would be a considerable undertaking and IMO not worth the trouble.

Any objections?  Otherwise I will commit.

Diego
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tools_link.diff
Type: text/x-diff
Size: 4206 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080604/267347e0/attachment.diff>