[MPlayer-dev-eng] [PATCH] prefer lavf pva and lmlm4 demuxers

[Ivo]

Hi,

Perhaps I should have been more verbose in my initial message :)

On Tuesday 03 June 2008 18:16, Reimar Döffinger wrote:
> On Tue, Jun 03, 2008 at 04:52:13PM +0200, Diego Biurrun wrote:
> > On Tue, Jun 03, 2008 at 03:18:00PM +0200, Ivo wrote:
> > > See $subject and patch.
> >
> > Well, you wrote those demuxers.  If you tested them and they work
> > better, I guess the patch is OK.

Yes, IMHO they work better and are both smaller than libmpdemux's. They 
were/are part of my effort to obsolete libmpdemux completely (except for 
binary blob library wrappers).

BTW I just noticed that the native LMLM4 demuxer has been broken completely 
in the last six months (it still worked when I was writing the lavf demuxer 
in december last year).

> I am not sure if there is a native alternative to these, so the real
> criteria is: If you are sure that the auto-detection of these formats is
> (almost) 100% reliable.

I have been fairly cautious with the probe functions. lmlm4's probe function 
returns either AVPROBE_SCORE_MAX/2 or 0 and pva returns either 
AVPROBE_SCORE_MAX/3, /5 or 0.

I have this patch in my local MPlayer tree for months and haven't noticed 
any misdetections, but I admit that I haven't played many different 
fileformats (mainly avi, asf and mp3). I could decrease lmlm4's maximum 
probe score to further limit the possibility of misdetection if you want, 
although it's in ffmpeg for about five months and nobody complained about 
ffmpeg wrongly detecting something as either lmlm4 or pva.

--Ivo