[MPlayer-dev-eng] [PATCH] Remove a warning in libmenu/menu_filesel.c

Diego Biurrun diego at biurrun.de
Tue Jun 3 18:11:37 CEST 2008


On Tue, Jun 03, 2008 at 03:09:47PM +0200, Guillaume LECERF wrote:
> 
> This patch removes :
> 
> libmenu/menu_filesel.c: In function 'open_dir':
> libmenu/menu_filesel.c:246: warning: comparison between signed and unsigned

Hmmm.

> --- libmenu/menu_filesel.c	(r??vision 26973)
> +++ libmenu/menu_filesel.c	(copie de travail)
> @@ -242,7 +242,7 @@
>      if (menu_chroot && !strcmp (dp->d_name,"..")) {
> -      int len = strlen (menu_chroot);
> +      unsigned int len = strlen (menu_chroot);
>        if ((strlen (mpriv->dir) == len || strlen (mpriv->dir) == len + 1)
>            && !strncmp (mpriv->dir, menu_chroot, len))

My strlen man page tells me that strlen returns size_t ...

Diego



More information about the MPlayer-dev-eng mailing list