[MPlayer-dev-eng] [PATCH] compute correct length for theora videos

[Reimar Döffinger]

On Sat, Jul 26, 2008 at 11:53:49PM +0200, A Mennucc wrote:
> the problem of theora length not showing correctly
> was reported as a Debian bug,  http://bugs.debian.org/464207
> 
> in May 11 there was an email with a proposed patch; but 
> after somediscussion, AFAICS it was not applied to SVN
> 
> I got a bit lost in reading the original
> email thread, so let me ask,
> why wasnt the patch applied to SVN?

Because nobody at all has a clue wtf that patch actually does beyond
that it is wrong (not meaning I _know_ it breaks something, but it
certainly is not how the code is supposed to work).

> or otherwise,
> would it be wise/safe for me to add the  patch into the 
> Debian packaging of MPlayer, so as to close the bug?

Certainly not!

> Indeed I tried it, and it seems to work.

I doubt you could catch even remotely all the possible cases, e.g.
I have some doubts it would work if you used -vc theora.
See SVN r27354 for a proper fix (not that I know for sure that that one
breaks nothing, but at least it is in line with the existing code and
removes outdated cruft instead of adding more).

Greetings,
Reimar Döffinger