[MPlayer-dev-eng] [PATCH] Xinerama full screen bug fix

[Reimar Döffinger]

Hello,
On Thu, Jul 24, 2008 at 06:48:59PM +0300, Georgi Chorbadzhiyski wrote:
> Around 07/24/08 18:22, Reimar Döffinger scribbled:
> > xineramascreen currently sets 3 things: the screen on which MPlayer
> > starts (unless the window manager interferes), the screen on which
> > MPlayer goes to fullscreen mode (unless the window manager interferes,
> > in which case the behaviour is as you describe) and the screen relative
> 
> I'm using kwin as WM so should I fill a bug about it for this behavior?

I doubt it is a bug, I think it behaves as the developers intended.
The whole way these things work is a bit unsatisfactory, but it was hard
enough to get even there, window managers always cause a lot of issues,
e.g. some did not respect the way MPlayer placed the window, so users
complained it did not open centered. Then MPlayer was made more
insistent on Window placement. But this caused other users to complain
because their window manager's custom placement did not work anymore,
and some window managers now probably hack around MPlayer's insistence
and so the mess continues to get worse instead of better.
This case is quite similar, in that it is unclear who is right about
what the users want: the window manager or MPlayer (and yes,
conceptually it should be the window manager, but I think they do not do
a good enough job by far for anything advanced).

> > Your particular patch would at least break consistency with behaviour on
> > Windows, and any patch that does not add a new option would at least remove
> > a currently working feature (going to fullscreen always on a certain
> > screen, no matter where the window is).
> 
> Ok, so what is the solution so the sequence described above works
> as I expected (go to full screen on which the mplayer window is)?
> 
> Probably using -geometry? If this is the recommended option should
> I send patch to manual page, describing xineramascreen option behavior
> wrt full screen and mplayer window position?

I did something like that and committed it. Still, improvements are
welcome.

Greetings,
Reimar Döffinger