[MPlayer-dev-eng] [PATCH] fbdev x and y positioning

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Tue Jul 22 20:59:20 CEST 2008


On Tue, Jul 22, 2008 at 02:44:39PM +0200, Sander wrote:
> I hope this simple patch can be added to the SVN-tree/latest release.

Not simple enough by far (well, ideally I would love someone to maintain
this properly and get rid of the mess, e.g. vidix should support
-geometry, too etc.

> @@ -998,7 +999,14 @@
>  	else
>  #endif
>  	{
> -	    int x_offset=0,y_offset=0;
> +	    int x_offset=0,y_offset=0, geo_width=0, geo_height=0;
> +	    if (vo_screenwidth && vo_screenheight)
> +	    {
> +	      if (vo_geometry)
> +	      {
> +	      	geometry(&x_offset, &y_offset, &geo_width, &geo_height, vo_screenwidth, vo_screenheight);
> +	      }
> +	    }

All this should be replaced with one single line:
> geometry(&x_offset, &y_offset, &out_width, &out_height, fb_xres, fb_yres);
And if it does not work it is probably due to bugs elsewhere which
should be fixed first.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list