[MPlayer-dev-eng] [PATCH]Add Dirac support via libavcodec and libavformat

[Diego Biurrun]

On Mon, Jul 21, 2008 at 08:48:42PM +1000, Anuradha Suraparaju wrote:
> 
> 
> --- configure	(revision 27330)
> +++ configure	(working copy)
> @@ -6659,6 +6668,81 @@
>  
> +      cc_check $_inc_dirac $_ld_dirac      && \
> +      _libdirac_lavc=yes                   && \
> +      _inc_extra="$_inc_extra $_inc_dirac" && \
> +      _ld_extra="$_ld_extra $_ld_dirac"

The backslashes are unnecessary.

> +      cc_check $_inc_schroedinger $_ld_schroedinger && \
> +      _libschroedinger_lavc=yes                     && \
> +      _inc_extra="$_inc_extra $_inc_schroedinger"   && \
> +      _ld_extra="$_ld_extra $_ld_schroedinger"

ditto

> +  # disable libdirac decoder if Schroedinger is available.
> +  _libavdecoders=`echo $_libavdecoders | sed -e s/LIBDIRAC_DECODER// `

Hmmm, wouldn't a preference in codecs.conf be enough?

> @@ -7830,6 +7914,8 @@
>  CONFIG_LIBMP3LAME=$_mp3lame_lavc
>  CONFIG_LIBVORBIS=$_libvorbis
>  CONFIG_LIBX264=$_x264_lavc
> +CONFIG_LIBDIRAC=$_libdirac_lavc
> +CONFIG_LIBSCHROEDINGER=$_libschroedinger_lavc
>  CONFIG_LIBXVID=$_xvid_lavc
>  CONFIG_MLIB = $_mlib
>  CONFIG_POSTPROC = yes
> @@ -8226,6 +8312,8 @@
>  $_def_faac_lavc
>  $_def_mp3lame_lavc
>  $_def_x264_lavc
> +$_def_libdirac_lavc
> +$_def_libschroedinger_lavc
>  $_def_xvid_lavc

Those used to be in alphabetical order...

> --- etc/codecs.conf	(revision 27330)
> +++ etc/codecs.conf	(working copy)
> @@ -708,6 +708,22 @@
>  
> +videocodec fflibdirac
> +  info "Dirac (through FFmpeg libdirac)"
> +  status working
> +  fourcc drac
> +  driver ffmpeg
> +  dll libdirac
> +  out I420,IYUV,422P,444P
> +
> +videocodec fflibschroedinger
> +  info "Dirac (through FFmpeg libschroedinger)"
> +  status working
> +  fourcc drac
> +  driver ffmpeg
> +  dll libschroedinger
> +  out I420,IYUV,422P,444P

I think you want to prefer schroedinger over dirac, so put the preferred
codec first.

Diego