[MPlayer-dev-eng] [PATCH]Add Dirac support via libavcodec and libavformat

[Anuradha Suraparaju]

Hi,

I've attached the updated patch to this email.

On Sun, 2008-07-20 at 22:09 +0200, Diego Biurrun wrote:
> On Fri, Jul 18, 2008 at 01:02:39PM +1000, Anuradha Suraparaju wrote:
> > 
> > This patch adds Dirac encoder and decoder support to MPlayer via FFmpeg.
> 
> > --- configure	(revision 27323)
> > +++ configure	(working copy)
> > @@ -292,6 +292,8 @@
> >    --disable-x264-lavc       disable x264 in libavcodec [autodetect]
> > +  --disable-libdirac-lavc   disable dirac in libavcodec [autodetect]
> > +  --disable-libschroedinger-lavc   disable dirac in libavcodec (Schroedinger decoder) [autodetect]
> 
> What is it called, "dirac", "Dirac" or "DIRAC"?
> 

Changed all references to the codec to Dirac.

> The last line is too long, break it or shorten it.
> 
> > @@ -6659,6 +6667,65 @@
> >  
> > +echocheck "libdirac"
> > +if test "$_libdirac_lavc" = auto ; then
> > +  cat > $TMPC << EOF
> > +#include <libdirac_encoder/dirac_encoder.h>
> > +#include <libdirac_decoder/dirac_parser.h>
> > +int main(void) 
> > +{
> > +    dirac_encoder_context_t enc_ctx;
> > +    dirac_decoder_t *dec_handle;
> > +    dirac_encoder_context_init(&enc_ctx, VIDEO_FORMAT_SD_576I50); 
> > +    dec_handle = dirac_decoder_init(0);
> > +	if (dec_handle)
> > +        dirac_decoder_close(dec_handle);
> > +    return 0;
> > +}
> 
> Lose tabs and trailing whitespace please, same in other places.
> 

Done

> > +_res_comment="in libavcodec: $_libdirac_lavc"
> 
> What is this comment good for?  It is never used outside of libavcodec..
> 

Removed the comment

> > --- etc/codecs.conf	(revision 27323)
> > +++ etc/codecs.conf	(working copy)
> > @@ -708,6 +708,22 @@
> >  
> > +videocodec fflibdirac
> > +  info "DIRAC (through ffmpeg libdirac)"
> > +
> > +videocodec fflibschroedinger
> > +  info "DIRAC (through ffmpeg libdirac)"
> 
> You are not allowed to misspell FFmpeg, ever :)
> 

Done.

> See my comment above about the name of [Dd][Ii][Rr][Aa][Cc].
> Diego

I addition to these changes, I have also modified the tests for libdirac
and libschroedinger in accordance with suggestions from Reimar Doffinger
and Dominik 'Rathann' Mierzejewski.

1. Ensured that the detection is disabled when static libavcodec is
disabled.

2. Using the --exists flag of pkg-config to check if the libraries are
installed.

Regards,
Anuradha
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer_trunk_revision_27330_dirac_support.diff
Type: text/x-patch
Size: 6146 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080721/bba8c20a/attachment.bin>