[MPlayer-dev-eng] [PATCH] bug with title_start and title_end in the MRL dvd://

[Mathieu SCHROETER]

Nico Sabbi a écrit :
> On Tuesday 08 July 2008 13:56:48 Mathieu SCHROETER wrote:
>> Mathieu SCHROETER a écrit :
>>> Hi,
>>>
>>> with dvd://,
>>> [[start_title]-end_title] are truncated to 2 chars each one.
>>>
>>> for example:
>>>
>>>  mplayer dvd://110-120
>>>
>>> plays title 11 and 12.. nevertheless, dvd_range() for a
>>> title is 1 to 255.
>>>
>>>
>>> This patch will fix the bug.
>> better patch..
>>
>> entbuf is a table of 10 chars..
>>
>>
>> Regards,
>> Mathieu
> 
> the truncation in the original code is wrong, but titles
> range from 1 to 99, IIRC

I've not enough knowledges in this domain but with some researchs
on the web.. you seem to be right..

In this case, this patch will fix at least the range when
start_title and end_title. are used.


*But* I don't know if the best is change this range or not because
with dvd://200 (for example), 200 is not truncated (and not tested
with this macro) and I've just a message like

  Invalid DVD title number: 200

from stream/stream_dvd.c.


Regards,
Mathieu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_dvd_range.patch
Type: text/x-patch
Size: 453 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080708/d4118629/attachment.bin>