[MPlayer-dev-eng] [PATCH] add optional device with dvd://
diego at biurrun.de
Sat Jul 5 15:08:36 CEST 2008
On Sat, Jul 05, 2008 at 02:53:58PM +0200, Nico Sabbi wrote:
> Il giorno sab, 05/07/2008 alle 13.25 +0200, Diego Biurrun ha scritto:
> > On Thu, Jul 03, 2008 at 02:35:56PM +0200, Nico Sabbi wrote:
> > > On Thursday 03 July 2008 12:47:49 Mathieu SCHROETER wrote:
> > > > Mathieu SCHROETER a écrit :
> > > > >+ if(!p->device)
> > > > >+ dvd_device_current = strdup(dvd_device ? dvd_device :
> > > >
> > > > DEFAULT_DVD_DEVICE);
> > > >
> > > > Sorry previous patch is wrong because a leak exists on
> > > > dvd_device_current. Now strdup() is only used on dvd_device
> > > > (if necessary)...
> > >
> > > thanks, I'll review it tonight
> > So you reviewed the patch and committed, but why FOR FUCK'S SAKE did you
> > have to leave out the documentation part?
> > How often do I have to repeat this? Never ever split off the
> > documentation part from a patch. It causes extra work for *you* as well
> > as for everybody else.
> > Oh, and this violates II.8 and II.11 of the policy, in case you care.
> I have to notice, quite disappointed, that although I don't have
> a track record of bad or incomplete commits (especially regarding
> the documentation parts) you used with me a language that you should
> have reserved to someone much more used than me to do bad things
I dunno who keeps splitting off documentation parts when committing
patches, too many people have done it too many times. It's a supremely
stupid idea to begin with and I have ranted against it countless times,
at least it feels like countless times.
So yes, I'm annoyed and ideg and yes, I want to drive home the point
that this is *not* to be done or to be repeated.
I could swear that you did split off documentation in the past, if
that is not true, I apologize for my harsh words to you. It was a
reaction out of the heat of the moment, as I said, I've mentioned it a
hundred times before.
> and to violate policy terms (Uoti being the first name come to my mind).
> It's a classical example of two weights and two measures.
No, I never requested your account to be closed.
More information about the MPlayer-dev-eng