[MPlayer-dev-eng] [PATCH] support run command with specific osd_level

Uoti Urpala uoti.urpala at pp1.inet.fi
Thu Jan 31 15:25:00 CET 2008


On Wed, 2008-01-30 at 21:51 +0800, Ulion wrote:
> ok, check this

The new status variables should be mpctx fields, not globals.

-            if (osd_level == 3) 
+            if (osd_level == 3 ||
+                    (mpctx->osd_show_percentage && force_seek_osd_level >= 3))

Code like this assumes a particular implementation of other OSD
functionality (that nothing but seeks sets osd_show_percentage) and
makes it harder to change. In general this makes OSD handling more
complex. I think it at least needs a good justification. What kind of
use cases do you have for this functionality?




More information about the MPlayer-dev-eng mailing list