[MPlayer-dev-eng] [PATCH] support run command with specific osd_level

[Ulion]

2008/1/30, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> On Wed, Jan 30, 2008 at 07:57:01PM +0800, Ulion wrote:
> > osd level is indeed max 3 in mplayer, I just limit the osd_level
> > prefix to fit the real osd level mplayer can accept, if some day the
> > osd level can greater than 9, I will have to rewrite this code, but
> > now we are not necessary support any osd_level prefix with an level
> > not accepted by mplayer. I just write the code accurately only works
> > for valid osd_level prefixes. Others' opinions?
>
> Well, but what will your code do in case a bad OSD level is given?
> Does it make more sense than my solution that would (well, this is an
> assumption, I did not test if it actually works out) allow a frontend
> developer to always display the maximum information - for all, including
> future MPlayer versions - by setting osdlevel to 99?
> And lastly, does checking the OSD level against the maximum provide
> _enough_ of an advantage to justify the more complex code?
> To every one: simple code is a _priority_. You should always choose the
> simpler code unless you know a good reason not to, not the other way
> round, as some people seem to be doing (note that your idea of simple
> code may differ from mine, but then just tell me so. In this case I find
> the lot of comparisons in the if make the thing really complex to
> understand).
>

ok, check this

-- 
Ulion
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: cmd_with_osd_level2.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080130/7b52fb49/attachment.asc>