[MPlayer-dev-eng] [RFC] defines for demux seek flags

[Uoti Urpala]

On Mon, 2008-01-28 at 16:52 +0100, Reimar Döffinger wrote:
> On Mon, Jan 28, 2008 at 03:00:56PM +0200, Uoti Urpala wrote:
> I really had not intended to have a split of how the flags are handled
> between mplayer.c and the demuxer code (and the resulting - admittedly
> one line - interface code). This would have been good if the idea was to
> give libmpdemux a proper API an MPlayer being a mere user of this
> library, but I don't think there is a point in such a break of semantics
> in the current situation.

I don't intend it to be a permanent state; as I said in a previous mail
I think the abs_seek_pos global should be removed and the MPlayer side
would change at that point.

> > Personally I'd be OK with committing the current version, but there are
> > still 2 things that I think could perhaps be done differently: the
> > naming of the 'percent' field and use of 'struct seekflags' vs a typedef
> > name.
> 
> Well, actually the naming was the only question I _intended_ to ask
> about in my first mail.

So do you want seekflags_t as the type name? I don't have a strong
opinion about that either way. I would like to change the 'percent' name
to something which doesn't incorrectly imply a range of 0...100, but
haven't come up with any good names. 'portion'/'proportion' don't sound
good to me either.