[MPlayer-dev-eng] [RFC] defines for demux seek flags

Rich Felker dalias at aerifal.cx
Mon Jan 28 07:50:48 CET 2008


On Sun, Jan 27, 2008 at 09:13:13AM +0100, Reimar Döffinger wrote:
> Hello,
> > @@ -79,14 +79,14 @@ static void demux_demuxers_seek(demuxer_t *demuxer,float rel_seek_secs,float aud
> >  
> >    if(priv->ad != priv->vd) {
> >      sh_audio_t* sh = (sh_audio_t*)demuxer->audio->sh;
> > -    demux_seek(priv->ad,pos,audio_delay,1);
> > +    demux_seek(priv->ad,pos,audio_delay,(struct seekflags){.absolute=1});
> 
> I find this really, really ugly.

Agree. Can we have an absolute policy that bitfields are forbidden in
MPlayer? They're ugly and have no practical benefit. They're an
unnecessary abstraction from just defining bitwise constants yourself,
and one which offers no potential for optimization.

And Uoti I'm not interested in wasting time flaming you so if you
reply, expect to be ignored. I've said what I came to say and I'm done
with this topic. Since we discussed it on several occasions before I
wonder if you proposed this nonsense just to bait me like the troll
you are..

Rich



More information about the MPlayer-dev-eng mailing list