[MPlayer-dev-eng] [PATCH] Color SPU rendering

[Evgeniy Stepanov]

On Sunday 27 January 2008 15:11:01 Benjamin Zores wrote:
> Ivan Kalvachev a écrit :
> > On Jan 27, 2008 1:21 PM, Benjamin Zores <ben at geexbox.org> wrote:
> >> Hi,
> >>
> >> In an attempt to start the color spu patchset for dvdnav, here's a first
> >> patch.
> >>
> >> It adds a new VO control that will be used to ask each vo which
> >> colorspace it can use to render SPUs.
> >> Next patch will implement this VOCTRL for each vo driver.
> >>
> >> Ok to apply ?
> >
> > I don't like the names. If you add something to the vo system it
> > should be generic, not dvdnav specific.
> > I hope the plan is spu rendering to replace the current osd one.
>
> See
> http://onebit.hu/pub/mplayer/dvdnav/20080119/dvdnav-patch-to-MPlayer-dev-SV
>N-r25787-4.1.3.patch
>
> to understand the whole changes that needs to be applied for complete
> SPU handling.

I think it's better to use EOSD for this instead of reimplementing colored 
subtitles rendering once again. There was a patch in this ML not too long 
ago.

It has some minor problems, the worst of them is huge code duplication in 
spudec. By the way, in the patch you linked, it is twice as bad :) I mean 
spudec_draw_scaled_* functions.