[MPlayer-dev-eng] DVDNAV Next Issues

Nico Sabbi Nicola.Sabbi at poste.it
Sun Jan 27 10:57:16 CET 2008


Il Sunday 27 January 2008 10:55:45 Reimar Döffinger ha scritto:
> Hello,
> On Sun, Jan 27, 2008 at 10:36:44AM +0100, Nico Sabbi wrote:
> > > +  if  (!(priv->state & NAV_FLAG_AUDIO_CHANGED)) return 0;
> > > +  if  (clear)
> > 
> > bad style, use if(x), for(x), while(x) NEVER spaces before or
> > after parenthesis or brackets
> 
> This is your personal preference though, at least I vastly prefer to have one
> space right after the keyword. Still, using two spaces is overkill ;-)
> _______________________________________________

in stream_dvdnav.c the style used is the one I described. My answer
was contextual to his patch



More information about the MPlayer-dev-eng mailing list