[MPlayer-dev-eng] [PATCH] set AVSEEK_FLAG_BACKWARD correctly in lavf demuxer

Michael Niedermayer michaelni at gmx.at
Sat Jan 26 22:58:47 CET 2008


On Sat, Jan 26, 2008 at 10:45:09PM +0100, Reimar Döffinger wrote:
> Hello,
> currently the condition for adding this flag is that the seek argument
> is < 0 and we are not seeking by percent.
> I think this makes no sense, 

svn blame says
20076     reimar
so your code makes no sense to you? ;)


> and instead the condition should be
> (relative seeking && argument < 0).
> Do you agree with attached patch?

well, its your code, feel free to change it as you see fit

may i by the way suggest that named constats be used in mplayer instead of
if(flags & 1) // blah

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080126/4990b80a/attachment.pgp>


More information about the MPlayer-dev-eng mailing list