[MPlayer-dev-eng] [PATCH] DVDNAV Still frames supprt

[Benjamin Zores]

Ötvös Attila a écrit :
> 2008. január 25. 23.30 dátummal Benjamin Zores ezt írta:
>> Ötvös Attila a écrit :
>>> 2008. január 25. 23.16 dátummal Benjamin Zores ezt írta:
>>> Hi Benjamin Zores!
>>>
>>>> I've removed this part cause it worked without.
>>>> Can you tell me what's the exact use of it ?
>>>> If it's needed I'll of course add it but I want to know first.
>>> This patch handle to end of still frame if used
>>> still_envent->still_length in dvdnav, eg.:
>>>
>>> still_length=10s
>>> call dvdnav_still_skip() if sh_video->pts > 10s
>>>
>>> Mplayer can't continue playing this still frames if "still-time" part
>>> removed.
> 
> Hi Ben!
> 
>> Sorry I don't quite get it.
> 
> I am sorry to say that my English knowledge isn't good.

I know, you say so in each mail you send ;-)

>> Someone can explain it a bit better ?
>> Why is this needed ? Still frames are well played even without as far as
>> I've tested.
> 
> dvdnav stream:
> <--- 1 ---> | <--- 2, still frame ; length=10s ---> | <--- 3 --->
> 
> Without:
> mplayer play 1
> mplayer play 2 but never exit from still frame
> 
> With:
> mplayer play 1
> mplayer play 2 and exit from still frame if pts>10s
> mplayer play 3

Ok, I'll add this then.
I can't reproduce this however.
Out of curiosity, does the 10s value has a sense or is it just an 
arbitrary value you choose (it's set in stream_dvdnav.c I know that) ?

Ben