[MPlayer-dev-eng] [PATCH] DVDNAV Still frames supprt

[Benjamin Zores]

Reimar Döffinger a écrit :
> Hello,
> On Fri, Jan 25, 2008 at 08:51:47PM +0100, Benjamin Zores wrote:
>> Reimar Döffinger a écrit :
>>
>>> Note that this is only a very quick review, I have not truly understood
>>> even half of the code...
>> Attached an updated patch.
>> This is much more likely to be understood.
> 
> Yes, looks like good cleanup to me.
> 
>> @@ -237,6 +286,10 @@
>>      int event;
>>  
>>      dvdnav_priv_t* priv=s->priv;
>> +    if (priv->state & NAV_FLAG_WAIT_READ) { /* read is suspended */
>> +      len = -1;
>> +      return len;
>> +    }
> 
> I guess this is this way because it will be extended later? If not that
> should be just return -1; and without the {} I think.

Attached an updated version with your comments in it.
Also, I've edited mp_dvdnav_save_smpi(...) not to return anything as it 
just saves the last still frame.

Ben
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-dvdnav-still-frame.diff
Type: text/x-diff
Size: 19743 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080125/3e2a730a/attachment.diff>