[MPlayer-dev-eng] [PATCH] DVDNAV Still frames supprt

[Uoti Urpala]

On Fri, 2008-01-25 at 14:45 +0100, Diego Biurrun wrote:
> Couldn't FFmpeg style be a workable compromise that all might accept?

What exactly do you mean by "FFmpeg style"? K&R indentation style with
spaces instead of tabs? FFmpeg doesn't actually follow it very
consistently - for example the opening and closing braces of a function
should be on a separate line but there's lots of code in FFmpeg where
the opening brace isn't. Or do you only mean "4 space indentation using
spaces only" leaving everything else unspecified?

I'm OK with K&R style myself. I don't see much benefit in forbidding use
of a tab instead of 8 leading spaces. Practically all tools I've seen
handle them as well as 8 spaces - in diff output an added '+' at the
start can cause a different output depending on whether a tab or spaces
follow, but that's minor and is balanced by slower moving over
whitespace made of spaces in some editors. I don't view using tabs vs 8
spaces as a major issue either way though (I am more strongly opposed to
using tab as some sort of indent metacharacter and pretending it doesn't
stand for 8 spaces, but nobody seems to be suggesting that here).