[MPlayer-dev-eng] [PATCH] DVDNAV Still frames supprt

[Reimar Döffinger]

On Fri, Jan 25, 2008 at 03:12:47PM +0200, Uoti Urpala wrote:
> On Fri, 2008-01-25 at 13:40 +0100, Reimar Döffinger wrote:
> > Fri, Jan 25, 2008 at 12:55:58PM +0100, Benjamin Zores wrote:
> > [...]
> > > Would it be possible for us to agree on a coding standard
> > 
> > As past discussion have proven, no.
> > But every maintainer can decide on one. Though we still do not have
> > a precommit scripts that can deny tabs on selected files (like
> > everything maintained by me)...
> 
> Having a maintainer-decided coding style can make sense for some files,
> but OTOH I wouldn't want to encourage that as a default practice.

I certainly do not want to encourage it at all.

> It'd
> make bureaucracy more important (who gets to be the maintainer that can
> select the style?), and if such per-file styles can be too detailed then
> making large changes involving lots of files from different maintainers
> becomes tedious (if you try to follow the exact style for each file).

Well, that is a rather theoretical problem. Most of the time you have to
be happy if we have someone who cares at all.
But, this gave me an idea: even if we can't decide on one coding style,
maybe we can decide on maybe exactly two, but with clear rules?
E.g. while I prefer 2 spaces indentation I'd be ready to switch the
files I maintain to ffmpeg-style...
And I can live with keeping one style that uses tabs, as long as it is
not the current fifty-ways-to-combine-tabs-and-spaces...

Greetings,
Reimar Döffinger