[MPlayer-dev-eng] [PATCH] DVDNAV Still frames supprt

[Benjamin Zores]

On Jan 25, 2008 11:47 AM, Reimar Döffinger
<Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

I'll send a patch with your comments in the evening.
I just wanted to come up on some points.

> > +  if (clear) {
> > +    priv->state &= ~NAV_FLAG_CELL_CHANGED;
> > +  }
>
> Useless {}

This will stay cause more lines will be added later for correct SPU handling.

> Indentation is only 2 elsewhere.

This is a point I wanted to talk about in a dedicated thread but as
you're starting with it.
We don't have any coding rules. Some files use a 2 spaces indent,
others a 4, some uses tabs, and some files mixes everything.
Would it be possible for us to agree on a coding standard (say ffmpeg
one or whatever), apply the "indent" command with the appropriate
options on all C and H files (maybe that can be done in post-commit
treatments as well) and we're done with this once for all ?

Ben

-- 
"My life, and by extension everyone else's is meaningless."
Bender, Futurama