[MPlayer-dev-eng] [PATCH] Allow sub_scale command to work with ASS subtitle renderer

[Evgeniy Stepanov]

On Wednesday 23 January 2008 01:53:16 Benjamin Zores wrote:
> Evgeniy Stepanov a écrit :
> > On Wednesday 23 January 2008 01:45:09 Benjamin Zores wrote:
> >> Evgeniy Stepanov a écrit :
> >>> On Tuesday 22 January 2008 22:16:17 Benjamin Zores wrote:
> >>>> Evgeniy Stepanov a écrit :
> >>>>> On Tuesday 22 January 2008 01:25:51 Benjamin Zores wrote:
> >>>>>> Hi,
> >>>>>>
> >>>>>> Attached patch does $subject.
> >>>>>> Can libass and mp_command maintainers review it ?
> >>>>>
> >>>>> Maybe I'm missing something trivial, but why can't
> >>>>> ass_set_font_scale() be called directly from property code, avoiding
> >>>>> all this mess with ass_force_reload ? This will also work with vf_vo.
> >>>>
> >>>> ass_renderer_t (needed by ass_set_font_scale) is not known from
> >>>> property code as far as i can tell :-(
> >>>
> >>> Right. Then, let's move ass_force_reload check to ass_mp.c to avoid
> >>> doing it both in vf_ass and vf_vo.
> >>
> >> Wiuld be nice.
> >>
> >> I just need to updated command.c this way.
> >> Now what is the best way finally ?
> >> Hack sub_scale or add a new command for ass_scale ?
> >
> > I'd prefer the former (hack sub_scale).
>
> then if everyone agree, I'll do that once you'll have your patches
> commited.

They are committed now.