[MPlayer-dev-eng] [PATCH] move free_font_desc() to font_load.h and use it everywhere it's possible

[Uoti Urpala]

On Tue, 2008-01-15 at 16:01 +0100, Guillaume LECERF wrote:
> 2008/1/15, Guillaume LECERF <foxcore at gmail.com>:
> > 2008/1/15, Uoti Urpala <uoti.urpala at pp1.inet.fi>:
> > > You said earlier that you're doing some kind of "font handling
> > > overview". Do you intend to use the newly created file for some other
> > > font-related functionality too?
> >
> > I'm trying to decouple font handling into osd font, sub font and menu
> > font, to be able to handle font scale independently, and btw resolve
> > an annoying sub scale bug which scales menu font with sub font.
> 
> And, to answer to your original question, I'm thinking about moving
> kerning() and render_one_glyph() and put there content under #ifdef,
> rather than having the #ifdef in font_load.h.
> What do you think about it ?

I haven't looked at it and apparently nobody else has replied in this
thread either. The patch here is probably OK, but OTOH it doesn't fix
any current functionality and only removes some code duplication from
the GUI (which is crap anyway). I think posting this kind of minor
cleanups as patches is often not worth it - anyone reviewing one could
make similar cleanups from scratch with effort about equal to the
overhead of verifying and applying patches.

If you have some dependent changes (with actual functionality benefits,
or more significant code cleanups) which require this to be applied
first I think it's better to post those at the same time.