[MPlayer-dev-eng] [PATCH] Allow sub_scale command to work with ASS subtitle renderer

Ulion ulion2002 at gmail.com
Tue Jan 22 04:03:27 CET 2008


2008/1/22, Benjamin Zores <ben at geexbox.org>:
> Reimar Döffinger a écrit :
> > Hello,
> > On Mon, Jan 21, 2008 at 11:25:51PM +0100, Benjamin Zores wrote:
> >> Attached patch does $subject.
> >> Can libass and mp_command maintainers review it ?
> >
> > Aren't the checks against ass_enabled necessary? Actually I'd think that
> > they are actually wrong, it might be possible to use both ass and normal
> > subtitle renderer at the same time, why should the code only change one
> > of those?
>
> How do you do this out of curiosity ?

when ass is enabled, there's still chance that mplayer uses the
freetype font sub_font or vo_font.
since ass_scale is no direct relationship with sub_scale or
font_scale, maybe it should be a standalone property.

-- 
Ulion



More information about the MPlayer-dev-eng mailing list