[MPlayer-dev-eng] [PATCH] Correctly support 32-bit raw MOV

[Diego Biurrun]

On Mon, Jan 21, 2008 at 03:15:02PM +0800, Timothy Lee wrote:
>
> The following patches fixes the support for 32-bit raw RGB video in MOV.  
> The colorspace of those video are IMGFMT_RGB32_1, which is not supported by 
> libswscale (as mentioned in 
> http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2007-December/055397.html).
>
> --- libmpcodecs/vf_bswap32.c	(revision 0)
> +++ libmpcodecs/vf_bswap32.c	(revision 0)
> @@ -0,0 +1,101 @@
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <string.h>
> +#include <inttypes.h>

Please add a standard license header and a line at the top that says what
this file is all about. 

> +static int put_image(struct vf_instance_s* vf, mp_image_t* mpi, double pts)
> +{
> +    long        i;
> +    uint32_t*   s;
> +    uint32_t*   d;
> +    mp_image_t* dmpi;
> +    

While you're at it, please lose the trailing whitespace.

> --- DOCS/man/en/mplayer.1	(revision 25798)
> +++ DOCS/man/en/mplayer.1	(working copy)
> @@ -7054,6 +7054,13 @@
>  .
> +.TP
> +.B bswap32
> +Converts RGB32x colorspace to BGR32, or BGR32x to RGB32 by swapping the byte
> +order of each 32-bit pixel.  This filter is automatically inserted to allow
> +the display of RGB32x and BGR32x data.

Place new sentences on new lines in the man page.

Diego