[MPlayer-dev-eng] [PATCH] filename extension bug fix for sub-auto detection

Ulion ulion2002 at gmail.com
Sun Jan 20 16:39:33 CET 2008


2008/1/19, Ulion <ulion2002 at gmail.com>:
> 2008/1/19, Reimar Doeffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > Hello,
> > On Sat, Jan 19, 2008 at 08:58:47PM +0800, Ulion wrote:
> > > current code of sub-auto detection does not support filename with
> > > extension length other 3, here's patch for it.
> > >
> > > if there's no objection, I will commit it tomorrow.
> >
> > The win32 part seems to have a typo, I guess it should be strrchr...
> > And could you be more precise which case exactly this fixes and how (i.e.
> > what happens with current code, what happens after this change?).
>
> sorry for the typo, i will fix it in my working copy.
> as what it fixed, for example:
> mplayer stream.dump
> this will got 'stream.' as first parameter for vobsub_open, and vobsub
> will try to open stream..idx and stream..sub.
> the origonal code always assume the filename extension has a length 3,
> then it will fail to auto-find any vobsub files with same filename
> main part.

commited with slight update.

-- 
Ulion



More information about the MPlayer-dev-eng mailing list