[MPlayer-dev-eng] [PATCH] lavf demuxer: always overwrite codec_tag for PCM formats

Roberto Togni rxt at rtogni.it
Sat Jan 19 16:21:57 CET 2008


On Sat, 19 Jan 2008 15:47:45 +0100
Roberto Togni <rxt at rtogni.it> wrote:

> On Sat, 19 Jan 2008 15:21:14 +0100
> Roberto Togni <rxt at rtogni.it> wrote:
> 
> > On Sun, 13 Jan 2008 18:40:21 +0100
> > Roberto Togni <rxt at rtogni.it> wrote:
> > 
> > > Hi all,
> > >  currently demuxer_lavf fails to set the correct codec format for some
> > > pcm files (eg. .au files, see samples/au/vrooom.au). This happens
> > > because the demuxer fills codec_tag with the tag used in the file (2
> > > for vrooom.au), and so MPlayer does not look into the codec_id =>
> > > codec_tag table to fix it. Also in this case the original codec_tag is
> > > already used by MPlayer (ms dpcm).
> > > lavf demuxer set the codec_id to the right format for pcm codecs.
> > > 
> > > This patch forces demuxer_lavf to ignore the codec_tag for pcm formats,
> > > and to always replace it with a tag computed from the CODEC_ID_PCM_*
> > > value.
> > > 
> > > It fixes the vrooom.au file and works with the other files I've tested.
> > > 
> > 
> > Updated version attached. I'll apply it soon if no complaints.
> > 
> 
> Really attached...
> 

Last version, fixed a typo made during rename, I'll apply tonight or
tomorrow.

Ciao,
 Roberto

-- 
Better is the enemy of good enough.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: demux_lavf.c.diff
Type: text/x-patch
Size: 1944 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080119/cbf1c365/attachment.bin>


More information about the MPlayer-dev-eng mailing list