[MPlayer-dev-eng] [PATCH] move free_font_desc() to font_load.h and use it everywhere it's possible

[Ivan Kalvachev]

On Jan 15, 2008 12:49 AM, Uoti Urpala <uoti.urpala at pp1.inet.fi> wrote:
> On Mon, 2008-01-14 at 21:42 +0000, Carl Eugen Hoyos wrote:
> > Uoti Urpala <uoti.urpala <at> pp1.inet.fi> writes:
> > > Making requests like the above (and not even worded as a request but in
> > > an unfriendly manner implying the original was "unacceptable")
> >
> > That was definitely not my intention: Please accept that I'm not nearly a native
> > speaker. I tried to explain what the "usual" (I think I used that word) way of
> > doing it is.
>
> Such a way of sending patches is not the "usual" method anywhere I know
> of except possibly for Michael's FFmpeg patches. We don't want patches
> with 1000+ lines of superfluous deletions on the list.
>
> > I didn't want to be unfriendly at all, merely trying to be helpful.
>
> In addition to the phrasing of your message and the questionable value
> of the patch format you asked for you also told the patch submitter what
> he must do with enough detail that you could have done it yourself. If
> you list the exact commands to use you could also run them. Refusing to
> do that and asking the patch submitter do it, basically making him jump
> through hoops to show he does things the way you want, is IMO quite rude
> which ever way you word it.
>
> If you wanted to be helpful you could have commented on the substance of
> the patch.
>
> > Apart from that: I expected your answer;-)
>
> If you expected the answer before sending your message then maybe you
> should have reconsidered sending it in the first place.
>

I'm with Uoti on this one.
Patch submitters should send small and easy to check patches. The
submitter should say if he is using code he haven't wrote.
It is the committer responsibility to commit the patch in a way that
would preserve the history, if he considers that it have to be done.

Now, focus back on the coding.