[MPlayer-dev-eng] [PATCH] move free_font_desc() to font_load.h and use it everywhere it's possible
Aurelien Jacobs
aurel at gnuage.org
Fri Jan 11 21:04:09 CET 2008
Guillaume LECERF wrote:
> 2008/1/11, Guillaume LECERF <foxcore at gmail.com>:
> > This patch is a part of the font handling review I'm doing.
> > free_font_desc() will be used to free not only freetype font but
> > also bitmap one, that's why i'm moving it out of font_load_ft.c.
> > This also helps simplifying some others parts.
>
> This new version inlines the function, to avoid multiple definitions
> in files including font_load.h.
But this don't avoid code duplication.
I see no reason to have this function inlined, and thus, no reason to
have it defined in a header. IMO you should move this function in
a .c file.
Aurel
More information about the MPlayer-dev-eng
mailing list