[MPlayer-dev-eng] [PATCH] demuxer-independent attachments
uoti.urpala at pp1.inet.fi
Tue Jan 8 12:20:05 CET 2008
On Tue, 2008-01-08 at 12:06 +0100, Nico Sabbi wrote:
> Il Tuesday 08 January 2008 11:54:45 Uoti Urpala ha scritto:
> > Well I still don't see what initialization and uninitialization
> > your comment would apply to here. Demuxer layer sets up the
> > attachment data and frees it when the demuxer is destroyed. Higher
> > level code uses that data and deals with the semantics of it. Looks
> > fine to me.
> in Evgeniy's patch the block
> + ass_add_font(ass_library, att->name, att->data,
> would end up in demux_open_stream()
No it wouldn't. In the original patch it did, but the context for your
original objection that I responded to was this:
>> The chunk with ass_add_font could be moved to mplayer.c, right
>> after the demuxer is opened. It makes sense because it deals with a
>> global (per-file, to be exact) object.
> it would be even worse: initialization and cleanup can't be split
> in different files.
IOW you specifically objected as "even worse" to a version which would
NOT have that in demuxer.c.
> +#ifdef USE_ASS
> +#include "libass/ass.h"
> +#include "libass/ass_mp.h"
> in demuxer.h is equally unclean, IMO
The patch did not add that to demuxer.h, but did add it to demuxer.c.
Probably it wouldn't be needed either with the proposed changed version.
More information about the MPlayer-dev-eng