[MPlayer-dev-eng] [PATCH] demuxer-independent attachments

[Nico Sabbi]

Il Tuesday 08 January 2008 10:52:47 Evgeniy Stepanov ha scritto:
> On Tuesday 08 January 2008 11:47:51 Nico Sabbi wrote:

> > I don't like it even remotely: the demuxer layer has nothing to
> > do with ass!
>
> The chunk with ass_add_font could be moved to mplayer.c, right
> after the demuxer is opened. It makes sense because it deals with a
> global (per-file, to be exact) object.

it would be even worse: initialization and cleanup can't be split
in different files.
A demuxer layer should only contain generic - and self-contained -
code to handle demuxers, not a wrapper for all demuxers.
If you find a generic solutions to handle attachments
without meddling with decoders' specific code (ass is a
decoder, after all) your code is welcome.

>
> What about ass_track in sh_sub, you also don't like it ? My other
> patch adds initialization code for it to demuxer.c (at the end of
> demux_open_stream).

I missed it