[MPlayer-dev-eng] [PATCH] Move SSA/ASS subtitles handling out?of mkv demuxer

Evgeniy Stepanov eugeni.stepanov at gmail.com
Tue Jan 8 00:16:15 CET 2008


On Monday 07 January 2008 00:28:53 Evgeniy Stepanov wrote:
> An updated version of the patch. Now all ass_tracks are created and
> initialized at the end of demux_open_stream. The actual demuxer just sets
> sh_sub->type='a', sh_sub->codecdata and feeds data packets to stream.
>
> I'm assuming that extradata is available after demuxer is opened. It seems
> that audio decoders also rely on this, so it must be true.

Another update. This time I also moved ass_free_track() call out of demuxer 
and put it in free_sh_sub(). Also I got rid of stupid global_ass_track, which 
does not work at all with multiple plain text subtitle tracks, by 
initializing sh_sub->ass_track both for 't' and for 'a' tracks. And, finally, 
codecdata is renamed to extradata.

Also, the first chunk contains a fix for subtitle track switching. Without a 
ds_free_packs() call, packets sometimes get parsed into the wrong ass_track.

It becomes quite a large change, so I'm going to start committing it in small 
parts very soon.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1.patch
Type: text/x-diff
Size: 10353 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080108/d36f974b/attachment.patch>


More information about the MPlayer-dev-eng mailing list