[MPlayer-dev-eng] [PATCH] avoid memleak of audio track extradata

Evgeniy Stepanov eugeni.stepanov at gmail.com
Mon Jan 7 15:18:57 CET 2008


On Sunday 06 January 2008 23:52:26 Reimar Döffinger wrote:
> Hello,
>
> On Sat, Jan 05, 2008 at 12:03:19AM +0300, Evgeniy Stepanov wrote:
> > sh_audio_t.codecdata is never deallocated. I hope it's ok to assume that
> > it does not contain anything fancy that would require deallocating it
> > from a demuxer.
>
> I guess it is ok, though the problem is that (IMO) codecdata actually
> should not exist, extra data should be appended after sh->wf...

wf is IMO ugly and inconvenient. Why store format description and extradata 
together ?

Patch applied.



More information about the MPlayer-dev-eng mailing list