[MPlayer-dev-eng] squelch some warnings (patches incl.)

[Michael Niedermayer]

On Tue, Feb 26, 2008 at 07:00:03PM +0100, Diego Biurrun wrote:
> On Mon, Feb 25, 2008 at 03:20:20AM +0100, Michael Niedermayer wrote:
> > 
> > Cleanup to snow is welcome, some examples:
> > * normalize {} placement
> 
> Elaborate what you mean, this is ambiguous, i.e. I'm not sure what your
> preference is.

NOT:
                for(x=0; x<w; x++)
                {
                    line[x] -= 128 << FRAC_BITS;
//                    buf[x + y*w]-= 128<<FRAC_BITS;
                }

but:
                for(x=0; x<w; x++){
                    line[x] -= 128 << FRAC_BITS;
//                    buf[x + y*w]-= 128<<FRAC_BITS;
                }

but please dont change {} for functions, they can be:
static void slice_buffer_flush(slice_buffer * buf)
{
    int i;
    for (i = 0; i < buf->line_count; i++){
        if (buf->line[i])
            slice_buffer_release(buf, i);
    }
}


> 
> The rest is done, 

not really:
        return;
    }

        for(mb_x=0; mb_x<=mb_w; mb_x++){
            add_yblock(s, 1, sb, old_buffer, dst8, obmc,

----
    if(sliced){
        s->dsp.inner_add_yblock(obmc, obmc_stride, block, b_w, b_h, src_x,src_y, src_stride, sb, add, dst8);
    }else
    for(y=0; y<b_h; y++){

...


> your turn now :)

done

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Thouse who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080229/f7c0e266/attachment.pgp>